-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/script parser #385
Merged
Merged
Feat/script parser #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows using `Keywords.GLOBAL` and literal `"GLOBAL"` interchangeably.
This commit will conflict with #328 and can be dropped.
This allows importing `Message` directly from `dff`, among other import improvements.
The master was merged into script-parser, and a slot parsing functionality was added.
# Conflicts: # chatsky/core/service/script_parsing.py # chatsky/pipeline/pipeline/pipeline.py # chatsky/script/core/keywords.py # chatsky/script/core/script.py # chatsky/script/responses/std_responses.py # chatsky/slots/slots.py
This also updates telegram tutorial to mention another way to import the interface.
It doesn't make it clear that it will overwrite all slots even if they are not successfully extracted. SlotManager.extract_all is still available.
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added option to initialize Pipeline from yaml/json files.
Changelog
Breaking changes
proc.ExtractAll
-- the function is unsafe as it overwrites the entire slot storage. it is still available as method of the slot managerFeatures
__init__
filesBug fixes
success_only
flagDevel
Checklist
To Consider
.ignore
files, scripts (such aslint
), distribution manifest (if files are added/deleted)